← 返回首页
Improve hover color behavior for selectors by almarklein · Pull Request #799 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Improve hover color behavior for selectors#799

Merged
kushalkolar merged 2 commits into
mainfrom
selector-color
Apr 15, 2025
Merged

Improve hover color behavior for selectors#799
kushalkolar merged 2 commits into
mainfrom
selector-color

Conversation

almarklein commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Ref #781

I noticed that the color of the selector was flickering during motion, as the mouse enters and exits the object. This PR freezes the color while ._moving, keeping track of color changes in a dict, and then applying that dict when the moving is done.

Notice how the corner vertex becomes highlighted as the mouse is released after dragging the edge:

Screen.Recording.2025-04-15.at.11.29.22.mov

github-actions Bot commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/selector-color

almarklein changed the title Improve hover color behavior Improve hover color behavior for selectors Apr 15, 2025

kushalkolar commented Apr 15, 2025

Copy link
Copy Markdown
Member

Thanks! I also want to refactor it to use the SelectorColorStates later

kushalkolar merged commit 5e910cc into main Apr 15, 2025
kushalkolar deleted the selector-color branch April 15, 2025 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar approved these changes
clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.