← 返回首页
Ruff by almarklein · Pull Request #785 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Ruff#785

Draft
almarklein wants to merge 5 commits into
mainfrom
ruff
Draft

Ruff#785
almarklein wants to merge 5 commits into
mainfrom
ruff

Conversation

almarklein commented Mar 31, 2025

Copy link
Copy Markdown
Collaborator
  • Update pyproject.toml
  • Update CI job.
  • Ran ruff . and ruff check --fix.
  • Fix more errors / add to ignore list.

Just a quick draft for now. Let's first see if this works for you. @kushalkolar you mentioned flake8 rules in pycharm. I would expect pycharm to pick up the ruff rules from the pyproject, but I'm not sure.

kushalkolar commented Apr 1, 2025

Copy link
Copy Markdown
Member

Thanks, it will take a while to go through this

almarklein commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks, it will take a while to go through this

Not sure if you mean fixing the errors that are still reported. There are quite a few, but many are similar. So with a bit of 💪 its should not take that long, in my experience.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar Awaiting requested review from kushalkolar kushalkolar will be requested when the pull request is marked ready for review kushalkolar is a code owner
clewis7 Awaiting requested review from clewis7 clewis7 will be requested when the pull request is marked ready for review clewis7 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.