← 返回首页
indexable graphic attributes by kushalkolar · Pull Request #78 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

indexable graphic attributes#78

Merged
kushalkolar merged 11 commits into
masterfrom
graphic-attrs
Dec 23, 2022
Merged

indexable graphic attributes#78
kushalkolar merged 11 commits into
masterfrom
graphic-attrs

Conversation

kushalkolar commented Dec 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

implements #77

GraphicFeatures to implement:

  • colors
  • sizes
  • data - mostly wrap current update_data methods, just pass the slice obj directly to geo.grid or geo.positions, and for positions update_range with indices parsed by slice object, otherwise entire thing with grid.
  • present (different from visibility) - not indexable
  • events for when these change

kushalkolar commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

color indexing is really nice :D

crazy_colors-2022-12-19_04.30.30.mp4

kushalkolar commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

this insanity is possible now: https://www.youtube.com/watch?v=j_gwi-Wf1Ao

also this which is more useful 😄

kushalkolar commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

For scatter we can make size an indexable feature too.

kushalkolar mentioned this pull request Dec 21, 2022
Closed
kushalkolar mentioned this pull request Dec 22, 2022
Closed
14 tasks

kushalkolar commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@EricThomson, @clewis7 , @ArjunPutcha
guys this is pretty epic, changing a GraphicFeature can trigger events 😄

Caitlin, pick_info formatting is the same as pygfx events to make life easy :D

features-events-2022-12-22_06.07.58.mp4

Will merge as soon as #61 is ready

kushalkolar mentioned this pull request Dec 22, 2022
Closed

EricThomson commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

Nice -- this will make certain other things so much easier.

kushalkolar merged commit 088f032 into master Dec 23, 2022
This was referenced Dec 25, 2022
Closed
Closed
Closed
kushalkolar deleted the graphic-attrs branch January 7, 2023 03:22
kushalkolar mentioned this pull request Jan 14, 2023
Open
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.