|
Grrr, I thought I had done git pull but that failed, so this is a bit behind :) |
Sorry, something went wrong.
Sure! I need to go through the codebase and my pycharm and decide how we want to configure ruff, I don't think there's a way to download the rules I'm currently ignoring in pycharm. flake8 is too strict sometimes so we ignore a bunch of things. |
Sorry, something went wrong.
|
So the deploy docs failure is because the secrets are only in the org. If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work. |
Sorry, something went wrong.
|
If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work. I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged? |
Sorry, something went wrong.
|
If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work. I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged? We can still see if the docs build step succeeded, but uploading to the server (to see the preview) requires the secrets so we skip it for external contributors for now until we figure out a better way. |
Sorry, something went wrong.
In future PRs I can do: