← 返回首页
Use pyproject.toml (superseded) by almarklein · Pull Request #779 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Use pyproject.toml (superseded)#779

Closed
almarklein wants to merge 6 commits into
fastplotlib:mainfrom
almarklein:pyproject
Closed

Use pyproject.toml (superseded)#779
almarklein wants to merge 6 commits into
fastplotlib:mainfrom
almarklein:pyproject

Conversation

Copy link
Copy Markdown
Collaborator

In future PRs I can do:

  • use same _version.py mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.
  • Formatting and linting with ruff, perhaps?

Copy link
Copy Markdown
Collaborator Author

Grrr, I thought I had done git pull but that failed, so this is a bit behind :)

Comment thread pyproject.toml Outdated Show resolved Hide resolved

Copy link
Copy Markdown
Member
  • use same _version.py mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.
  • Formatting and linting with ruff, perhaps?

Sure! I need to go through the codebase and my pycharm and decide how we want to configure ruff, I don't think there's a way to download the rules I'm currently ignoring in pycharm. flake8 is too strict sometimes so we ignore a bunch of things.

Comment thread fastplotlib/layouts/_graphic_methods_mixin.py Show resolved Hide resolved
Comment thread pyproject.toml Show resolved Hide resolved

Copy link
Copy Markdown
Member

So the deploy docs failure is because the secrets are only in the org. If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

Copy link
Copy Markdown
Collaborator Author

If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged?

kushalkolar commented Mar 29, 2025
edited
Loading

Copy link
Copy Markdown
Member

If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged?

We can still see if the docs build step succeeded, but uploading to the server (to see the preview) requires the secrets so we skip it for external contributors for now until we figure out a better way.

almarklein mentioned this pull request Mar 29, 2025

Copy link
Copy Markdown
Collaborator Author

Superseded by #782

almarklein closed this Mar 29, 2025
almarklein changed the title Use pyproject.toml Use pyproject.toml (superseded) Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.