← 返回首页
fix comment, fix doc example readme file by kushalkolar · Pull Request #769 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix comment, fix doc example readme file#769

Merged
clewis7 merged 2 commits into
mainfrom
fix-comment-fix-doc-readme
Mar 17, 2025
Merged

fix comment, fix doc example readme file#769
clewis7 merged 2 commits into
mainfrom
fix-comment-fix-doc-readme

Conversation

Copy link
Copy Markdown
Member

old comment lingering from when graphics were weakrefs (before we dug into the ways ipython docs gc)

kushalkolar requested a review from clewis7 as a code owner March 17, 2025 02:16

Copy link
Copy Markdown
Member Author

Failure makes no sense, I can't produce locally O_O

def test_gray(): fig = fpl.Figure() ig = fig[0, 0].add_image(GRAY_IMAGE) assert isinstance(ig, fpl.ImageGraphic) ig.add_event_handler( event_handler, "data", "cmap", "vmin", "vmax", "interpolation", "cmap_interpolation", ) # make sure entire data is the same npt.assert_almost_equal(ig.data.value, GRAY_IMAGE) # since this entire image is under the wgpu max texture limit, # the entire image should be in the single Texture buffer npt.assert_almost_equal(ig.data.buffer[0, 0].data, GRAY_IMAGE) > ig.cmap = "viridis" tests/test_image_graphic.py:89: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ fastplotlib/graphics/image.py:205: in cmap self._cmap.set_value(self, name) fastplotlib/graphics/_features/_base.py:346: in set_value_wrapper raise exc # set_value has raised. The line above and the lines 2+ steps below are probably more relevant! fastplotlib/graphics/_features/_base.py:343: in set_value_wrapper set_value(self, graphic_or_key, value) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <fastplotlib.graphics._features._image.ImageCmap object at 0x114c90410> graphic = ImageGraphic, value = 'viridis' @block_reentrance def set_value(self, graphic, value: str): new_colors = make_colors(256, value) > graphic._material.map.texture.data[:] = new_colors E AttributeError: 'TextureMap' object has no attribute 'data'

Copy link
Copy Markdown
Member Author

Ah the change is because cmap now returns a TextureMap instead of a Texture

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-comment-fix-doc-readme

Copy link
Copy Markdown
Member Author

@clewis7 gtg!

clewis7 merged commit 61d7962 into main Mar 17, 2025
clewis7 deleted the fix-comment-fix-doc-readme branch March 17, 2025 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.