Sorry, something went wrong.
|
biggest issue right now is when resizing, I think the canvas resizes a while before the new rect sizes are ready which causes wgpu draw errors this is Qt specific: pygfx/rendercanvas#56 |
Sorry, something went wrong.
|
@clewis7 ready for review! Any ubuntu tests won't pass on github actions due to pygfx/pygfx#979 but the mac tests should all pass (except for pygfx-release, the ones using pygfx@main should pass) also tests are all passing locally |
Sorry, something went wrong.
|
all relevant tests passing now except the docs build but you fixed that in another PR so this is good for another look! |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
First step towards #315 and #670
Things will change once pygfx refactors their viewport stuff, but I think it will be easier to adopt those changes after this PR since it makes Figure manage the bbox of all subplots. I think this is a good separation of responsibilities. After this PR arbitrary bboxes for subplots can be implemented.
Introduces one minor breaking API change, Subplot.position no longer exists but it's unlikely anyone was using that.
Todo in future PR: