← 返回首页
removes size attribute use for histogram component of imagewidget by apasarkar · Pull Request #712 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

removes size attribute use for histogram component of imagewidget#712

Merged
kushalkolar merged 1 commit into
fastplotlib:mainfrom
apasarkar:lazy_array_attributes
Feb 5, 2025
Merged

removes size attribute use for histogram component of imagewidget#712
kushalkolar merged 1 commit into
fastplotlib:mainfrom
apasarkar:lazy_array_attributes

Conversation

Copy link
Copy Markdown
Collaborator

Addresses issue #711, verified that .size is no longer a "required" property for lazy arrays used in ImageWidget.

Copy link
Copy Markdown
Member

LGTM but tests are failing due to this: #713 (comment)

will try to figure out in a few days

kushalkolar merged commit ef4399d into fastplotlib:main Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.