← 返回首页
add macos-latest to CI matrix by kushalkolar · Pull Request #707 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

add macos-latest to CI matrix#707

Merged
clewis7 merged 9 commits into
mainfrom
add-mac-ci
Jan 25, 2025
Merged

add macos-latest to CI matrix#707
clewis7 merged 9 commits into
mainfrom
add-mac-ci

Conversation

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member

let's see if this works

kushalkolar requested a review from clewis7 as a code owner January 25, 2025 07:23

github-actions Bot commented Jan 25, 2025 •
edited
Loading

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/add-mac-ci

kushalkolar commented Jan 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

mac test failing because there is a slight diff for the lines-data test, will increase tolerance to 0.1 for nb tests, still lower than the default tolerance from the original pygfx code which was 0.2 .

kushalkolar mentioned this pull request Jan 25, 2025
Closed

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

ok so basically everything that isn't pygfx-latest is passing! 🥳

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

This mean we'll have over 50 tests with all the variants, but once pygfx becomes more stable it'll go down by half which seems normal for projects of this scope (I looked at matplotlib etc.)

clewis7 merged commit 0336e26 into main Jan 25, 2025
clewis7 deleted the add-mac-ci branch January 25, 2025 18:05

kushalkolar commented Jan 26, 2025

Copy link
Copy Markdown
Member Author

@almarklein thought you might be interested to know that tests now work with the github mac runners 😄

almarklein commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

O, that's really cool! 🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.