← 返回首页
update screenshot by kushalkolar · Pull Request #700 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

update screenshot#700

Merged
clewis7 merged 3 commits into
mainfrom
fix-screenshot
Jan 21, 2025
Merged

update screenshot#700
clewis7 merged 3 commits into
mainfrom
fix-screenshot

Conversation

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member

my hunch is this is due to pygfx/pygfx#945

when set_data() is used, it wouldn't immediately update the camera related stuff which is why the axes don't appear on the initial draw after set_data(), as a user we don't notice it because that draw only lasts for a few milliseconds.

kushalkolar requested a review from clewis7 as a code owner January 21, 2025 07:03

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

@clewis7 this should fix the current CI failure

github-actions Bot commented Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-screenshot

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

I also changed the CI timeout from 10 mins to 15, for whatever reason it took llvmpipe etc. 7 mins to install. Maybe something changed on github actions 🤷‍♂️ . Anyways jobs usually finish in 5 mins, maybe stuff gets cached so if it hits a new machine or something it takes longer.

kushalkolar mentioned this pull request Jan 21, 2025
Merged

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

idk what's taking so long with apt install on github actions lately, relaxed the timeout time to 25 mins 🤷‍♂️

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

wtf, so now all the jobs finished within 5mins?? Must be some caching things or apt servers were slow for some reason during those earlier runs

clewis7 merged commit 959006e into main Jan 21, 2025
clewis7 deleted the fix-screenshot branch January 21, 2025 14:53
kushalkolar mentioned this pull request Jan 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.