← 返回首页
update contrib guide, add developer notes by clewis7 · Pull Request #667 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

update contrib guide, add developer notes#667

Merged
clewis7 merged 6 commits into
mainfrom
contrib-guide
Oct 25, 2024
Merged

update contrib guide, add developer notes#667
clewis7 merged 6 commits into
mainfrom
contrib-guide

Conversation

clewis7 commented Oct 24, 2024

Copy link
Copy Markdown
Member

supersedes #580

Because something wonky happened with the iris dataset and all of the changes with imgui, it was easier to just open a new PR for this

clewis7 mentioned this pull request Oct 24, 2024
Closed
5 tasks
clewis7 marked this pull request as ready for review October 24, 2024 15:29
clewis7 requested a review from kushalkolar as a code owner October 24, 2024 15:29

github-actions Bot commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/contrib-guide

kushalkolar commented Oct 24, 2024

Copy link
Copy Markdown
Member

Some formatting issues and also add the developer docs as a separate dir, like user guide, and have a toc page with the graphics and plotarea in the toctree

kushalkolar requested changes Oct 25, 2024
View reviewed changes
Comment thread docs/source/developer_notes/graphics.rst Outdated Show resolved Hide resolved
clewis7 commented Oct 25, 2024
View reviewed changes
Comment thread docs/source/developer_notes/graphics.rst Outdated Show resolved Hide resolved
kushalkolar requested changes Oct 25, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Outdated Show resolved Hide resolved
Comment thread CONTRIBUTING.md Outdated Show resolved Hide resolved
clewis7 commented Oct 25, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Outdated Show resolved Hide resolved
clewis7 commented Oct 25, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Outdated Show resolved Hide resolved
clewis7 merged commit 7a0e40f into main Oct 25, 2024
clewis7 deleted the contrib-guide branch October 25, 2024 21:28
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
update contrib guide, add developer notes (fastplotlib#667) …
8fbb940
* new pr for contrib guide * fix warning * fix formatting issues * reformat * Update docs/source/developer_notes/graphics.rst * Apply suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.