← 返回首页
remove ipywidget code from selectors and cleanup docstrings by kushalkolar · Pull Request #644 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

remove ipywidget code from selectors and cleanup docstrings#644

Merged
clewis7 merged 4 commits into
mainfrom
remove-ipywidget-code
Oct 18, 2024
Merged

remove ipywidget code from selectors and cleanup docstrings#644
clewis7 merged 4 commits into
mainfrom
remove-ipywidget-code

Conversation

kushalkolar commented Oct 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

since we've not switched to imgui we shouldn't have any GUI specific code in the core library, this really cleans up the selectors 😄

kushalkolar marked this pull request as ready for review October 8, 2024 15:22
kushalkolar requested a review from clewis7 as a code owner October 8, 2024 15:22

kushalkolar commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

Forgot to regen API docs, I really need to use precommit

kushalkolar force-pushed the remove-ipywidget-code branch from 33fad93 to 4660257 Compare October 17, 2024 03:22

github-actions Bot commented Oct 17, 2024

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-ipywidget-code

kushalkolar commented Oct 17, 2024

Copy link
Copy Markdown
Member Author

@clewis7 gtg after review, I removed ipywidget code within the selectors but I also cleaned up the docstrings, there were some remnants stating "slider" from over a year ago.

clewis7 approved these changes Oct 17, 2024
View reviewed changes

clewis7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

I don't know if you want to do this in this PR or a different PR but we had talked about making fill_color, vertex_color, and edge_color properties (re: issue with kevin's viz when changing the selector colors and then events set them back to original)

kushalkolar commented Oct 17, 2024

Copy link
Copy Markdown
Member Author

Let's do that separately

clewis7 merged commit eb4b3f8 into main Oct 18, 2024
kushalkolar deleted the remove-ipywidget-code branch October 18, 2024 12:34
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
remove ipywidget code from selectors and cleanup docstrings (fastplot… …
b8ae851
…lib#644) * remove ipywidget code from linear selector and cleanup docstrings * remove ipywidget code from LinearRegionSelector, cleanup docstrings * remove a method * update API docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.