← 返回首页
change basis of axes by kushalkolar · Pull Request #567 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

change basis of axes#567

Merged
kushalkolar merged 3 commits into
mainfrom
axes-basis
Aug 2, 2024
Merged

change basis of axes#567
kushalkolar merged 3 commits into
mainfrom
axes-basis

Conversation

kushalkolar commented Jul 29, 2024
edited
Loading

Copy link
Copy Markdown
Member

closes #561

WIP, seems to be ok in 2D, something wonky in 3D. Those blue axes should be pointing out towards the red points. And one ruler is completely MIA

using pylinalg.quat_from_vecs to create the quaternion to rotate the axes world object.

kushalkolar requested a review from clewis7 July 29, 2024 05:15

Copy link
Copy Markdown
Member Author

it was an indexing error 🙃

This is really nice 😄

I think once I figure out how to get the new (xmin, ymin), (xmax, ymax) for the rulers to account for rotation good to go.

kushalkolar marked this pull request as ready for review August 2, 2024 17:17
kushalkolar merged commit 68cf50b into main Aug 2, 2024
kushalkolar deleted the axes-basis branch August 4, 2024 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding axes to represent a different basis

2 participants

Footer

© 2026 GitHub, Inc.