catchup with pygfx, remove checks for pending uploads from tests by kushalkolar · Pull Request #562 · fastplotlib/fastplotlib · GitHub
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer
You can’t perform that action at this time.
after pygfx/pygfx#795 Buffer._gfx_pending_uploads no longer exists. There are new methods Buffer.update_full() and Buffer.update_indices() which we can make use of instead of us having to check these ourselves.
One purpose of our test was to make sure that indices chosen to be uploaded correctly mapped to a range and it seems like we don't have to worry about this anymore, thanks @almarklein ! 😄
We should change our BufferManagers to make use of the new buffer upload options! :D