← 返回首页
Get nearest graphics by kushalkolar · Pull Request #519 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Get nearest graphics#519

Merged
kushalkolar merged 11 commits into
mainfrom
get-nearest
Jun 18, 2024
Merged

Get nearest graphics#519
kushalkolar merged 11 commits into
mainfrom
get-nearest

Conversation

kushalkolar commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

closes #514

WIP, need to finish edge method

from itertools import product import numpy as np import fastplotlib as fpl def make_circle(center, radius: float, n_points: int = 75) -> np.ndarray: theta = np.linspace(0, 2 * np.pi, n_points) xs = radius * np.sin(theta) ys = radius * np.cos(theta) return np.column_stack([xs, ys]) + center spatial_dims = (100, 100) circles = list() for center in product(range(0, spatial_dims[0], 15), range(0, spatial_dims[1], 15)): circles.append(make_circle(center, 5, n_points=75)) fig = fpl.Figure() lines = fig[0, 0].add_line_collection(circles, colors="r", thickness=5) def highlight_nearest(ev): lines.colors = "r" xy = fig[0, 0].map_screen_to_world(ev)[:-1] nearest = fig[0, 0].get_nearest_graphics(xy, method="center", subset=lines) nearest[0].colors = "w" fig.renderer.add_event_handler(highlight_nearest, "pointer_move") fig.show()
get_nearest-2024-06-17_00.35.24.mp4

kushalkolar commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

@clewis7 @apasarkar what about just skipping the edge method, using the bbox is actually useless for many real use cases like this where there is lots of overlap 🙃

clewis7 commented Jun 17, 2024

Copy link
Copy Markdown
Member

This looks amazing!! I am okay with skipping edge. When I think about doing something like clicking a contour I would be clicking near the center...

kushalkolar commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

I think I'm going to make this a function in fastplotlib.utils

kushalkolar marked this pull request as ready for review June 18, 2024 04:10
kushalkolar requested a review from clewis7 as a code owner June 18, 2024 04:10

kushalkolar commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

@clewis7 ready for review!

clewis7 reviewed Jun 18, 2024
View reviewed changes
Comment thread fastplotlib/utils/_plot_helpers.py
Comment on lines +36 to +37
if not all(isinstance(g, Graphic) for g in graphics):
raise TypeError("all elements of `graphics` must be Graphic objects")

clewis7 Jun 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Should there also be a check for if all the graphics are in the same subplot? Or would that not make a difference?

kushalkolar Jun 18, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

We leave that to the user, so it's just a very simple function unaware of plot areas

clewis7 reviewed Jun 18, 2024
View reviewed changes

clewis7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

See question...

kushalkolar merged commit a07636c into main Jun 18, 2024
kushalkolar deleted the get-nearest branch June 18, 2024 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plot area nearest graphics method

2 participants

Footer

© 2026 GitHub, Inc.