← 返回首页
gridplot controllers kwarg is back, other improvements to gp by kushalkolar · Pull Request #477 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gridplot controllers kwarg is back, other improvements to gp#477

Merged
kushalkolar merged 7 commits into
mainfrom
gp-controllers-kwarg
Apr 7, 2024
Merged

gridplot controllers kwarg is back, other improvements to gp#477
kushalkolar merged 7 commits into
mainfrom
gp-controllers-kwarg

Conversation

kushalkolar commented Apr 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

closes #425

  • controllers kwarg to Gridplot to manually pass pygfx.Controller instance(s), all other controller kwargs are ignored if this is passed
  • add @cameras and @controllers properties to Gridplot
  • tests the various cameras and controllers kwargs, and changing cameras and controllers after gridplot creation

kushalkolar marked this pull request as ready for review April 7, 2024 09:57
kushalkolar requested a review from clewis7 as a code owner April 7, 2024 09:57
kushalkolar merged commit 418a73b into main Apr 7, 2024
kushalkolar deleted the gp-controllers-kwarg branch April 7, 2024 10:45
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread .github/workflows/ci.yml Show resolved Hide resolved
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread tests/test_gridplot.py Show resolved Hide resolved
clewis7 reviewed Apr 9, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
Comment thread fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Directly pass Controller instances to GridPlot

2 participants

Footer

© 2026 GitHub, Inc.