← 返回首页
Add black to setup in optional feature set for tests by EricThomson · Pull Request #436 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Add black to setup in optional feature set for tests#436

Merged
kushalkolar merged 8 commits into
fastplotlib:mainfrom
EricThomson:add_black_setup
Mar 20, 2024
Merged

Add black to setup in optional feature set for tests#436
kushalkolar merged 8 commits into
fastplotlib:mainfrom
EricThomson:add_black_setup

Conversation

EricThomson commented Mar 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #435.

Also changes .gitignore, adding VS Code config file.

EricThomson marked this pull request as ready for review March 18, 2024 04:07

kushalkolar commented Mar 18, 2024 via email

Copy link
Copy Markdown
Member

kushalkolar requested changes Mar 18, 2024
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated Show resolved Hide resolved

EricThomson commented Mar 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

At point now where not sure if black.yml is ok and finding problems in code, or it is still bad.

kushalkolar commented Mar 19, 2024

Copy link
Copy Markdown
Member

ok so we need to black our nbs too 😆

kushalkolar requested changes Mar 20, 2024
View reviewed changes

kushalkolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

one last thing and should be good to go! :D

Comment thread .github/workflows/black.yml Show resolved Hide resolved
kushalkolar merged commit 576ccbf into fastplotlib:main Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should black be in setup.py optional deps for tests?

2 participants

Footer

© 2026 GitHub, Inc.