← 返回首页
A bit of black by almarklein · Pull Request #433 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

A bit of black#433

Merged
kushalkolar merged 2 commits into
mainfrom
gen_methods
Mar 14, 2024
Merged

A bit of black#433
kushalkolar merged 2 commits into
mainfrom
gen_methods

Conversation

almarklein commented Mar 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • The script that generates graphic_methods_mixin.py now also blackens the code. (could take this nearly verbatim from the wgpu codegen)
  • Blackend a few more files.

Now only the examples are unblacked. I can add that too if you want, but I was not sure if certain PR's may be affected.

almarklein commented Mar 13, 2024

Copy link
Copy Markdown
Collaborator Author

I think it makes sense to move the generate_x scripts out of the fastplotlib dir into a special scripts dir in the root of the repo, since they're not part of the library. But generate_colormaps.py is touched in #390, so I left it in place.

kushalkolar commented Mar 13, 2024

Copy link
Copy Markdown
Member

I think it makes sense to move the generate_x scripts out of the fastplotlib dir into a special scripts dir in the root of the repo, since they're not part of the library.

Makes sense!

But generate_colormaps.py is touched in #390, so I left it in place.

Yup I need to get back to that PR, probably next week. But generate_colormaps.py will disappear after we incorporate Talley's cmap lib

almarklein marked this pull request as ready for review March 14, 2024 08:15
kushalkolar merged commit 8ebbe5c into main Mar 14, 2024
kushalkolar deleted the gen_methods branch March 20, 2024 02:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.