← 返回首页
fix bug when remove_graphic() is used by kushalkolar · Pull Request #405 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix bug when remove_graphic() is used#405

Merged
kushalkolar merged 1 commit into
mainfrom
fix-add-remove-graphic
Feb 19, 2024
Merged

fix bug when remove_graphic() is used#405
kushalkolar merged 1 commit into
mainfrom
fix-add-remove-graphic

Conversation

Copy link
Copy Markdown
Member

No description provided.

kushalkolar commented Feb 19, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

Notebook tests are failing due to new changes in pygfx we haven't caught up with yet, merging this since it's working locally. Will catchup with pygfx@main soon.

kushalkolar merged commit cf4a04b into main Feb 19, 2024
kushalkolar deleted the fix-add-remove-graphic branch February 26, 2024 06:58
kushalkolar added a commit that referenced this pull request Feb 29, 2024
* start legends, not functional yet * add faq (#400) * fix bug when remove_graphic() is used (#405) * add 'Deleted' as a graphic feature (#404) * very basic adding line legends works * use OrderedDict for legend items * allow accessing legend items via Graphic, updating colors works * legend mesh resizes properly * remove legend items and reorder works * enforce all legend labels to be unique * add legends property to PlotArea * checks for Graphic name * highlight linegraphic when legend item is clicked * legend is moveable * remove weird characters that were committed for some reason * progress on legend grid placement, not yet working * max_rows works for legend * just allow max_rows kwarg for legends, no cols * line that snuck in from another branch * small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Footer

© 2026 GitHub, Inc.