← 返回首页
add `Deleted` as a graphic feature by kushalkolar · Pull Request #404 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

add Deleted as a graphic feature#404

Merged
kushalkolar merged 1 commit into
mainfrom
deleted-feature
Feb 20, 2024
Merged

add Deleted as a graphic feature#404
kushalkolar merged 1 commit into
mainfrom
deleted-feature

Conversation

kushalkolar commented Feb 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This makes it possible to create callbacks to do things when a Graphic is deleted from a PlotArea.

garbage collection is actinng wonky again so I need to fix that too... nevermind, I think was accessing stuff users wouldn't normally access in jupyter so ipython was clinging onto it, as usual 😄

This also changes all feature_events class attributes to be a set.

Useage:

kushalkolar requested a review from clewis7 February 19, 2024 10:32
kushalkolar marked this pull request as ready for review February 19, 2024 10:36
kushalkolar mentioned this pull request Feb 19, 2024
Merged

kushalkolar commented Feb 19, 2024

Copy link
Copy Markdown
Member Author

@clewis7 notebook tests are failing due to a new change in pygfx which we haven't caught up to yet, but I want to merge this anyways and deal with the pygfx changes later.

clewis7 reviewed Feb 19, 2024
View reviewed changes

clewis7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Had a couple of clarifying questions? Has been too long since I have looked at this. Otherwise, LGTM!

Comment thread fastplotlib/graphics/_features/_deleted.py
def __init__(self, parent, value: bool):
super(Deleted, self).__init__(parent, value)

def _set(self, value: bool):

clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

So, this will get triggered when __del__ is called and self.deleted = True is set?

clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

How are we preventing users from if a graphic has been deleted to still having reference to the graphic and trying to say something silly like graphic.deleted=False? Will this throw an error if the graphic has already been deleted? I would assume so because there will be no reference.

kushalkolar Feb 20, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

So, this will get triggered when __del__ is called and self.deleted = True is set?

Yes, Graphic.__del__ sets self.deleted = True https://github.com/fastplotlib/fastplotlib/pull/404/files#diff-a57994ecff1cde4e05c8175265219f0b5200da144ce8733b9eb560c09bcea7ddR179

How are we preventing users from if a graphic has been deleted to still having reference to the graphic and trying to say something silly like graphic.deleted=False? Will this throw an error if the graphic has already been deleted? I would assume so because there will be no reference.

Since users are only given acccess to weakreferences, it will throw a reference error if they try to do anything with a deleted Graphic.

Comment thread fastplotlib/graphics/_features/_deleted.py

pick_info = {
"index": None,
"collection-index": self._collection_index,

clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

What is the difference here between index vs collection-index? Also, collection-index could be None if the graphic is not a CollectionGraphic, no?

clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

It seems like index will always be None?

kushalkolar Feb 20, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

index is buffer index, used for things like data and colors features. Not used here since it's not relevant

kushalkolar merged commit 78f1d2a into main Feb 20, 2024
kushalkolar added a commit that referenced this pull request Feb 20, 2024
add 'Deleted' as a graphic feature (#404)
d537a4e
kushalkolar deleted the deleted-feature branch February 26, 2024 06:58
kushalkolar added a commit that referenced this pull request Feb 29, 2024
legends, part 1 (#406) …
8919d7c
* start legends, not functional yet * add faq (#400) * fix bug when remove_graphic() is used (#405) * add 'Deleted' as a graphic feature (#404) * very basic adding line legends works * use OrderedDict for legend items * allow accessing legend items via Graphic, updating colors works * legend mesh resizes properly * remove legend items and reorder works * enforce all legend labels to be unique * add legends property to PlotArea * checks for Graphic name * highlight linegraphic when legend item is clicked * legend is moveable * remove weird characters that were committed for some reason * progress on legend grid placement, not yet working * max_rows works for legend * just allow max_rows kwarg for legends, no cols * line that snuck in from another branch * small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.