← 返回首页
update contrib guide for git-lfs by tlambert03 · Pull Request #391 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

update contrib guide for git-lfs#391

Merged
kushalkolar merged 1 commit into
fastplotlib:mainfrom
tlambert03:update-contrib
Dec 5, 2023
Merged

update contrib guide for git-lfs#391
kushalkolar merged 1 commit into
fastplotlib:mainfrom
tlambert03:update-contrib

Conversation

tlambert03 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

closes #388

@kushalkolar, how's this read?

also, do you ever commit stuff in diffs/? or is it worth adding it to git ignore?

kushalkolar requested changes Dec 4, 2023
View reviewed changes
Comment thread CONTRIBUTING.md Show resolved Hide resolved

kushalkolar commented Dec 4, 2023

Copy link
Copy Markdown
Member

Thanks for this! :D

Yes it should be safe to add diffs/* to .gitignore, but keep the diffs dir.

kushalkolar commented Dec 4, 2023

Copy link
Copy Markdown
Member

Nevermind you're right sorry! We don't have an empty diffs dir in main (@clewis7 wrote the entire test suite so I'm sometimes unfamiliar with the details here)

tlambert03 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Right, so the main question (for you all), is whether you ever intend to check stuff into diffs, or if it's always the byproduct product of a test. If the latter, just add it to gitignore, and then developers don't need to pay any special attention to it.

kushalkolar commented Dec 5, 2023

Copy link
Copy Markdown
Member

Yup it's indeed the latter!

kushalkolar commented Dec 5, 2023

Copy link
Copy Markdown
Member

Bypassing CI for this since no source files are touched.

kushalkolar merged commit 9621740 into fastplotlib:main Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests: OSError: [Errno 24] Too many open files

2 participants

Footer

© 2026 GitHub, Inc.