← 返回首页
fix normalize_min_max by kushalkolar · Pull Request #353 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix normalize_min_max#353

Merged
kushalkolar merged 2 commits into
mainfrom
fix-min-max-norm
Nov 2, 2023
Merged

fix normalize_min_max#353
kushalkolar merged 2 commits into
mainfrom
fix-min-max-norm

Conversation

Copy link
Copy Markdown
Member

closes #352

kushalkolar requested a review from clewis7 November 1, 2023 08:38

Copy link
Copy Markdown
Member Author

Really bizarre failure only on python3.10 in the nb tests O_O. Will just rerun the test, maybe github actions is being weird.

=================================== FAILURES =================================== _ /home/runner/work/fastplotlib/fastplotlib/examples/notebooks/lines_cmap.ipynb _ --------------------------------------------------------------------------- # for testing, ignore notebook_finished() --------------------------------------------------------------------------- AssertionError Traceback (most recent call last) Cell In[19], line 2 1 # for testing, ignore ----> 2 notebook_finished() File ~/work/fastplotlib/fastplotlib/examples/notebooks/nb_test_utils.py:85, in notebook_finished() 83 def notebook_finished(): 84 if len(FAILURES) > 0: ---> 85 raise AssertionError( 86 f"Failures for plots:\n{FAILURES}" 87 ) AssertionError: Failures for plots: ['lines-cmap-white', 'lines-cmap-jet', 'lines-cmap-jet-values', 'lines-cmap-jet-values-cosine', 'lines-cmap-viridis', 'lines-cmap-viridis-values', 'lines-cmap-tab-10'] __ /home/runner/work/fastplotlib/fastplotlib/examples/notebooks/simple.ipynb ___ --------------------------------------------------------------------------- # for testing, ignore notebook_finished() --------------------------------------------------------------------------- AssertionError Traceback (most recent call last) Cell In[64], line 2 1 # for testing, ignore ----> 2 notebook_finished() File ~/work/fastplotlib/fastplotlib/examples/notebooks/nb_test_utils.py:85, in notebook_finished() 83 def notebook_finished(): 84 if len(FAILURES) > 0: ---> 85 raise AssertionError( 86 f"Failures for plots:\n{FAILURES}" 87 ) AssertionError: Failures for plots: ['camera', 'astronaut', 'astronaut_RGB', 'lines', 'lines-colors', 'lines-data', 'lines-underlay', 'lines-3d'] =========================== short test summary info ============================ FAILED examples/notebooks/lines_cmap.ipynb:: - ['lines-cmap-white', 'lines-cmap-jet', 'lines-cmap-jet-values', 'lines-cmap-jet-values-cosine', 'lines-cmap-viridis', 'lines-cmap-viridis-values', 'lines-cmap-tab-10'] FAILED examples/notebooks/simple.ipynb:: - ['camera', 'astronaut', 'astronaut_RGB', 'lines', 'lines-colors', 'lines-data', 'lines-underlay', 'lines-3d'] ======================== 2 failed, 10 passed in 47.03s ========================= Error: Process completed with exit code 1.

kushalkolar merged commit 430f513 into main Nov 2, 2023
kushalkolar deleted the fix-min-max-norm branch November 4, 2023 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weird floating point error in setter for cmap_values

1 participant

Footer

© 2026 GitHub, Inc.