← 返回首页
make hlut widget optional by clewis7 · Pull Request #351 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

make hlut widget optional#351

Merged
kushalkolar merged 2 commits into
mainfrom
iw_hlut
Nov 3, 2023
Merged

make hlut widget optional#351
kushalkolar merged 2 commits into
mainfrom
iw_hlut

Conversation

clewis7 commented Oct 31, 2023

Copy link
Copy Markdown
Member

No description provided.

clewis7 commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

would be nice to add an hlut button to the toolbar so it can be generated after imagewidget instantiation if a user wanted one for a specific subplot!

kushalkolar requested changes Oct 31, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Outdated Show resolved Hide resolved

kushalkolar commented Oct 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

would be nice to add an hlut button to the toolbar so it can be generated after imagewidget instantiation if a user wanted one for a specific subplot!

I think this is feature creep, they can create and add it programmatically if they need that level of customization?

kushalkolar commented Nov 1, 2023

Copy link
Copy Markdown
Member

Also add kwarg to specify subsample dims for HistogramLut widget?

kushalkolar reviewed Nov 1, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Outdated Show resolved Hide resolved
clewis7 commented Nov 1, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Outdated Show resolved Hide resolved
clewis7 commented Nov 1, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Outdated Show resolved Hide resolved

clewis7 commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

Also add kwarg to specify subsample dims for HistogramLut widget?

@kushalkolar anything more than number of bins? or you want a dict that allows user to pass nbins and flank?

kushalkolar commented Nov 1, 2023

Copy link
Copy Markdown
Member

Also add kwarg to specify subsample dims for HistogramLut widget?

@kushalkolar anything more than number of bins? or you want a dict that allows user to pass nbins and flank?

Just a tuple of its to specify the max size?

kushalkolar marked this pull request as ready for review November 3, 2023 04:06

kushalkolar commented Nov 3, 2023

Copy link
Copy Markdown
Member

going to merge this, see #359 for the subsample

kushalkolar merged commit c1cf47f into main Nov 3, 2023
kushalkolar deleted the iw_hlut branch November 4, 2023 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.