← 返回首页
refactor text graphic by clewis7 · Pull Request #335 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

refactor text graphic#335

Merged
kushalkolar merged 6 commits into
mainfrom
text_graphic
Oct 27, 2023
Merged

refactor text graphic#335
kushalkolar merged 6 commits into
mainfrom
text_graphic

Conversation

clewis7 commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

#305

Refactored the text graphic to use properties and some more features of pygfx TextGeometry

clewis7 commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

kushalkolar requested changes Oct 25, 2023
View reviewed changes
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Show resolved Hide resolved

kushalkolar commented Oct 26, 2023

Copy link
Copy Markdown
Member

can you run black on only the textgraphic, else this will cause merge conflicts with every other WIP PR.

we should look into ruff longterm

kushalkolar requested changes Oct 26, 2023
View reviewed changes
Comment thread docs/source/api/graphics/TextGraphic.rst Show resolved Hide resolved

kushalkolar commented Oct 26, 2023

Copy link
Copy Markdown
Member

seems like the wrong commit got reverted, this is still changing the rest of the codebase

kushalkolar requested changes Oct 27, 2023
View reviewed changes

kushalkolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Also regenerate the add graphics mixin

Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
kushalkolar marked this pull request as ready for review October 27, 2023 18:32
kushalkolar mentioned this pull request Oct 27, 2023
Closed
4 tasks
kushalkolar merged commit 2cd6d52 into main Oct 27, 2023
kushalkolar deleted the text_graphic branch October 29, 2023 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.