Selection vector improve#1061

apasarkar

Addresses #1047.

Concrete changes:

Includes logic to block re-entrance when selections are changed
Includes more compact code for adding selectors to make things more declarative. Now the user just provides the selector + a global index --> local index mapping. This mapping is given by a 1D array (or a dictionary). The inverse mapping and event handler logic is dealt with internally within SelectionVector.
Fills in missing functionality: clear selectables, remove, remove_selector

value can also be Iterable[int | None]

relative import

deleting for now because SelectionVector just works with VisibilitySelector + HighlightSelector (+ subclasses)

list[Callable] for the handlers

code comment above when type signature is large

this doesn't do anything, can just be self._selection = new

@kushalkolar

@kushalkolar thought about this -- this does something. if the input is any iterable other than a list, it makes the input a list.

call it local_indices

get rid of stale code

this should be a scalar now and not a vector

they can also specify a mapping Callable directly

apasarkar added 2 commits June 11, 2026 13:03

Full selection vector implementation

c6308e3

Includes some documentation at top of SelectionVector

393b48d

apasarkar requested review from clewis7 and kushalkolar as code owners June 11, 2026 05:15

apasarkar marked this pull request as draft June 11, 2026 05:16

apasarkar added 2 commits June 12, 2026 04:04

Minor typing fix in linear selector selection setter

e80f963

First working version with selection vector

174f861

kushalkolar requested changes Jun 12, 2026

View reviewed changes

apasarkar added 2 commits June 13, 2026 12:50

Reworks the logic for adding selectors, improves some documentation, … …

3a4dfde

…adds partial instead of lambda functions, improves typing in highlight selector

Fixes casting bug in the integer version of the code

701250d

                       # selector -> (map, map_inv)
                       self._selectors: dict[
-                          SelectorProtocol | MultiSelectorProtocol, tuple[Callable, Callable]
+                          SelectorProtocol | MultiSelectorProtocol, tuple[Callable, Callable, list]

+                          self._block_reentrance = True
+                          if isinstance(new, Integral):
+                              new = [new]
+                          self._selection = [i for i in new]

+                          self._selection = [i for i in new]
+                          # iterate through each selector that operates in its own "local" space
+                          for selector_local, (map_, map_inv, handler) in self._selectors.items():
+                              cumulated_output = []

+                              for value in new:
+                                  curr_indices = map_(value)
+                                  cumulated_output.append(curr_indices)
+                              # indices_local = map_(new)

                       ),
                   ):
+                      """
+                      User specifies (1) the selector and (2) The master --> local index mapping. This

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Selection vector improve#1061