← 返回首页
📝 Clarify `async` technical details in `UploadFile` documentation by achyutadixit · Pull Request #15696 · fastapi/fastapi · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

📝 Clarify async technical details in UploadFile documentation#15696

Open
achyutadixit wants to merge 1 commit into
fastapi:masterfrom
achyutadixit:patch-1
Open

📝 Clarify async technical details in UploadFile documentation#15696
achyutadixit wants to merge 1 commit into
fastapi:masterfrom
achyutadixit:patch-1

Conversation

Copy link
Copy Markdown

Description

This PR clarifies the misleading "async Technical Details" note in the UploadFile documentation.

File: docs/en/docs/tutorial/request-files.md
https://github.com/fastapi/fastapi/blob/master/docs/en/docs/tutorial/request-files.md

Current Issue

The current note states:

"When you use the async methods, FastAPI runs the file methods in a threadpool and awaits for them."

While technically accurate, this is misleading because:

  1. It doesn't explain why threadpool is necessary
  2. It implies ALL async operations use threadpools (contradicting async/await principles)
  3. It lacks context about the actual benefit: maintaining event loop concurrency

Solution

The updated note now explains:

  • Why: Threadpool is used to make blocking file I/O operations non-blocking
  • Benefit: Allows the async event loop to process other requests while file operations are in progress
  • Context: This is a special case for blocking I/O, not the norm for async operations

Technical Background

Evidence from source code (fastapi/datastructures.py):
Each async method has a docstring: "To be awaitable, compatible with async, this is run in threadpool."

Evidence from documentation (docs/en/docs/async.md, line 418):
FastAPI explicitly states threadpool is used for def functions, implying async def should NOT use threadpool except for blocking I/O (which requires special handling).

New Text

/// note | `async` Technical Details The `UploadFile` async methods wrap blocking file I/O operations and run them in a threadpool to make them non-blocking. This allows the async event loop to process other requests while file operations are in progress, which is essential for maintaining the non-blocking nature of your `async def` path operation functions. ///

- Explain why threadpool is used (blocking file I/O needs to be non-blocking) - Clarify this maintains event loop concurrency - Remove misleading implication that all async operations use threadpool - Connect to the broader async/await philosophy of FastAPI
github-actions Bot added the docs Documentation about how to use FastAPI label Jun 6, 2026

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

YuriiMotov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I wouldn't say that current note text is "misleading" - for those who read docs in the order everything should be clear.

I think it just "can be a bit better".
But this edit makes sense to me.

Passing this to Sebastian for review

YuriiMotov changed the title docs: Clarify misleading async technical details in UploadFile documentation 📝 Clarify async technical details in UploadFile documentation Jun 6, 2026
YuriiMotov changed the title 📝 Clarify async technical details in UploadFile documentation 📝 Clarify async technical details in UploadFile documentation Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.