There was a problem hiding this comment.
Awesome thank you for the PR!
I have a few worries, mainly that if the VS Code team ever adds new dependencies, or removes this one, or adds extensions with conflicting dependencies, we will probably not notice those until the npm module breaks again. And also since we are not referencing the extension's lockfile we might install a different version leading to subtly different behavior between the GitHub and npm releases.
There are a few ways we could resolve these issues, but what do you think about this strategy:
So each extension with external dependencies will have their own shrinkwrap with its unique dependencies which should make the npm install match the GitHub release perfectly.
Sorry, something went wrong.
|
Pushed a small CI follow-up for the script-unit failure: the new script/tests call jq, but the Alpine script-test job only installed bats and checkbashisms. The workflow now installs jq too. Local verification:
|
Sorry, something went wrong.
Fixes #7806
Summary
Test plan