← 返回首页
Fix: wrong key used to access log-cache root endpoint. Fix cloudfoundry#1251 by Lokowandtg · Pull Request #1252 · cloudfoundry/cf-java-client · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Fix: wrong key used to access log-cache root endpoint. Fix cloudfoundry#1251#1252

Merged
Kehrlann merged 3 commits into
cloudfoundry:mainfrom
Lokowandtg:fixLogCacheRootAccess
Jun 13, 2025
Merged

Fix: wrong key used to access log-cache root endpoint. Fix cloudfoundry#1251#1252
Kehrlann merged 3 commits into
cloudfoundry:mainfrom
Lokowandtg:fixLogCacheRootAccess

Conversation

Copy link
Copy Markdown
Contributor

Fix #1251.
The key to access the log-cache URL hay a typo.
Add one testcase to the normal access with the key.
Add one testcase for the fallback if the root endpoint does not provide the value. This test shows that the letters "api" in the remaining URL are also replaced, leading to invalid results.

import org.cloudfoundry.logcache.v1.ReadRequest;
import org.cloudfoundry.logcache.v1.ReadResponse;
import org.cloudfoundry.reactor.ConnectionContext;
import org.cloudfoundry.reactor.RootProvider;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

unused import, please remove

Copy link
Copy Markdown
Contributor

please rebase on main

Lokowandtg force-pushed the fixLogCacheRootAccess branch from e35de47 to b2435fa Compare February 20, 2025 18:16

linux-foundation-easycla Bot commented Feb 20, 2025
edited
Loading

Copy link
Copy Markdown



The committers listed above are authorized under a signed CLA.

Lokowandtg force-pushed the fixLogCacheRootAccess branch from b2435fa to 6ec4124 Compare February 24, 2025 17:06
Kehrlann self-assigned this May 28, 2025
Kehrlann added this to the 6.0.0 release milestone May 28, 2025
Lokowandtg force-pushed the fixLogCacheRootAccess branch from 6ec4124 to 10b8c0d Compare June 11, 2025 20:29
Kehrlann self-requested a review June 13, 2025 08:05
Hide details View details Kehrlann merged commit 97aff65 into cloudfoundry:main Jun 13, 2025
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in key name when accessing log-cache from root endpoint

3 participants

Footer

© 2026 GitHub, Inc.