← 返回首页
Use yaml instance instead of static variable to enable threadsaftey by LitschiW · Pull Request #1246 · cloudfoundry/cf-java-client · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Use yaml instance instead of static variable to enable threadsaftey#1246

Open
LitschiW wants to merge 2 commits into
cloudfoundry:mainfrom
LitschiW:patch-1
Open

Use yaml instance instead of static variable to enable threadsaftey#1246
LitschiW wants to merge 2 commits into
cloudfoundry:mainfrom
LitschiW:patch-1

Conversation

LitschiW commented Oct 14, 2024

Copy link
Copy Markdown

Fixes #1245

linux-foundation-easycla Bot commented Oct 14, 2024 •
edited
Loading

Copy link
Copy Markdown



The committers listed above are authorized under a signed CLA.

Lokowandtg approved these changes Dec 3, 2024
View reviewed changes

Lokowandtg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

Lokowandtg commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

We have the same coding in class ApplicationManifestUtilsCommon. Could you apply the changes there as well?

Lokowandtg approved these changes Dec 3, 2024
View reviewed changes

Lokowandtg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

anthonydahanne approved these changes Feb 11, 2025
View reviewed changes

anthonydahanne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

looks good to me!

Kehrlann self-assigned this May 28, 2025

Kehrlann commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@LitschiW would you mind rebasing on top of main (rebase, not merge) before I merge this, please?

Kehrlann commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

@LitschiW Additionally, this does not compile: ApplicationManifestUtils uses ApplicationManifestUtilsCommon#YAML.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anthonydahanne anthonydahanne approved these changes
Lokowandtg Lokowandtg approved these changes

Assignees

Kehrlann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ApplicationManifestUtilsV3#write is not threadsafe

4 participants

Footer

© 2026 GitHub, Inc.