← 返回首页
Adopting V3 API in routes by radoslav-tomov · Pull Request #1194 · cloudfoundry/cf-java-client · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Adopting V3 API in routes#1194

Closed
radoslav-tomov wants to merge 7 commits into
cloudfoundry:mainfrom
radoslav-tomov:routes
Closed

Adopting V3 API in routes#1194
radoslav-tomov wants to merge 7 commits into
cloudfoundry:mainfrom
radoslav-tomov:routes

Conversation

radoslav-tomov commented Sep 7, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Change adopts V3 API in the following operations:

  • check
  • deleteOrphanedRoutes
  • delete

anthonydahanne left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

please keep reformatting in a standalone commit; it makes it really hard to review if changes and reformatting (please configure your IDE not to reformat every single class you updated) are bundled together; thank you!

Actually even better: please stick to the existing code style; some IDEs like IntelliJ recognize the current layout and do not try to reduce lines to a specific length

@@ -30,7 +30,7 @@
import org.cloudfoundry.client.v2.routes.DeleteRouteResponse;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

unused import

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

also line 61: import static org.cloudfoundry.util.tuple.TupleUtils.predicate;

import org.cloudfoundry.client.v2.jobs.GetJobResponse;
import org.cloudfoundry.client.v2.jobs.JobEntity;

import org.cloudfoundry.client.v3.jobs.GetJobRequest;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lots of unused imports here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@anthonydahanne Thanks for checking it out. Sure, will do.

Copy link
Copy Markdown
Contributor Author

@anthonydahanne Apologies for the formatting. I've been using the VS Code and it's default styling is a bit off. I've removed the unused imports and reformatted via the standard Eclipse google java style.

Copy link
Copy Markdown
Contributor

@anthonydahanne Apologies for the formatting. I've been using the VS Code and it's default styling is a bit off. I've removed the unused imports and reformatted via the standard Eclipse google java style.

Thanks for the effort, but unfortunately, a lot of unchanged code is still reformatted.

We need to enforce formatting using CI to make sure we won't be having this discussion anymore.

I'll let you know when we have it.

Thanks for your patience

Copy link
Copy Markdown
Contributor Author

@anthonydahanne Ok. Thanks.

anthonydahanne added a commit to anthonydahanne/cf-java-client that referenced this pull request Feb 13, 2024
anthonydahanne mentioned this pull request Feb 13, 2024
anthonydahanne added a commit to anthonydahanne/cf-java-client that referenced this pull request Feb 13, 2024

beyhan commented Feb 15, 2024

Copy link
Copy Markdown
Member

This could be closed now because #1217 introduced this change.

Copy link
Copy Markdown
Contributor

Closed via #1217

Yavor16 pushed a commit to Yavor16/cf-java-client-fork that referenced this pull request Dec 5, 2024
Yavor16 added a commit to Yavor16/cf-java-client-fork that referenced this pull request Dec 6, 2024
add integration test Upgrade JUnit4 to JUnit5 Java 17 and 21 CI is now manually triggered ala workflow_dispatch Revert removal of Test import * make sure that we also compile the integration tests during Github CI updates Conditonal CloudFoundry version based test to JUnit 5 Do not use ExtendWith * when the extension has a mandatory field to initialize, because ExtendWith only works with default constructor Junit4 to Junit4 Integration Tests migration * add the extension registration declaratively (using an annotation) Modified getOrganizationId() & getSpaceId() as per V3 adding security groups v3 create api adding create security group impl and tests adding get security group api and tests adding get security group impl + test adding list security groups impl + api adding update security group api adding update security group api v3 impl adding security groups delete api v3 impl and tests adding bind running/staging security group v3 api adding bind impl adding unbind security group adding list running/staging api and tests adding create security group test adding integration tests adding integration tests fixing setup/teardown fixing integration tests refactoring integration tests Ignore .idea/ for real now Migration to Junit5 * tests from radoslav commits Make integration tests chatty * cause they have interesting things to display Add globally enabled Spotless apply; include integration-test mask off non-permission bits apply spotless formatting * on top of Hans Schulz "mask off non-permission bits" porting check route to v3 api porting delete orphaned routes pushing delete route cleaning up leftovers in tests applying default style and fixing missing imports PR cloudfoundry#1194: rebase and format with spotless defaultApplication-api minor changes Modified Junit tests to adopt V3 changes. rebasing 1173 fix health check type serialization Update tcp-routes.yml Update tcp-routes.yml Update IntegrationTestConfiguration.java fix formatting test
Yavor16 added a commit to Yavor16/cf-java-client-fork that referenced this pull request Dec 6, 2024
add integration test Upgrade JUnit4 to JUnit5 Java 17 and 21 CI is now manually triggered ala workflow_dispatch Revert removal of Test import * make sure that we also compile the integration tests during Github CI updates Conditonal CloudFoundry version based test to JUnit 5 Do not use ExtendWith * when the extension has a mandatory field to initialize, because ExtendWith only works with default constructor Junit4 to Junit4 Integration Tests migration * add the extension registration declaratively (using an annotation) Modified getOrganizationId() & getSpaceId() as per V3 adding security groups v3 create api adding create security group impl and tests adding get security group api and tests adding get security group impl + test adding list security groups impl + api adding update security group api adding update security group api v3 impl adding security groups delete api v3 impl and tests adding bind running/staging security group v3 api adding bind impl adding unbind security group adding list running/staging api and tests adding create security group test adding integration tests adding integration tests fixing setup/teardown fixing integration tests refactoring integration tests Ignore .idea/ for real now Migration to Junit5 * tests from radoslav commits Make integration tests chatty * cause they have interesting things to display Add globally enabled Spotless apply; include integration-test mask off non-permission bits apply spotless formatting * on top of Hans Schulz "mask off non-permission bits" porting check route to v3 api porting delete orphaned routes pushing delete route cleaning up leftovers in tests applying default style and fixing missing imports PR cloudfoundry#1194: rebase and format with spotless defaultApplication-api minor changes Modified Junit tests to adopt V3 changes. rebasing 1173 fix health check type serialization Update tcp-routes.yml Update tcp-routes.yml Update IntegrationTestConfiguration.java fix formatting test
anthonydahanne pushed a commit that referenced this pull request Dec 6, 2024
add integration test Upgrade JUnit4 to JUnit5 Java 17 and 21 CI is now manually triggered ala workflow_dispatch Revert removal of Test import * make sure that we also compile the integration tests during Github CI updates Conditonal CloudFoundry version based test to JUnit 5 Do not use ExtendWith * when the extension has a mandatory field to initialize, because ExtendWith only works with default constructor Junit4 to Junit4 Integration Tests migration * add the extension registration declaratively (using an annotation) Modified getOrganizationId() & getSpaceId() as per V3 adding security groups v3 create api adding create security group impl and tests adding get security group api and tests adding get security group impl + test adding list security groups impl + api adding update security group api adding update security group api v3 impl adding security groups delete api v3 impl and tests adding bind running/staging security group v3 api adding bind impl adding unbind security group adding list running/staging api and tests adding create security group test adding integration tests adding integration tests fixing setup/teardown fixing integration tests refactoring integration tests Ignore .idea/ for real now Migration to Junit5 * tests from radoslav commits Make integration tests chatty * cause they have interesting things to display Add globally enabled Spotless apply; include integration-test mask off non-permission bits apply spotless formatting * on top of Hans Schulz "mask off non-permission bits" porting check route to v3 api porting delete orphaned routes pushing delete route cleaning up leftovers in tests applying default style and fixing missing imports PR #1194: rebase and format with spotless defaultApplication-api minor changes Modified Junit tests to adopt V3 changes. rebasing 1173 fix health check type serialization Update tcp-routes.yml Update tcp-routes.yml Update IntegrationTestConfiguration.java fix formatting test
anthonydahanne pushed a commit that referenced this pull request Dec 6, 2024
add integration test Upgrade JUnit4 to JUnit5 Java 17 and 21 CI is now manually triggered ala workflow_dispatch Revert removal of Test import * make sure that we also compile the integration tests during Github CI updates Conditonal CloudFoundry version based test to JUnit 5 Do not use ExtendWith * when the extension has a mandatory field to initialize, because ExtendWith only works with default constructor Junit4 to Junit4 Integration Tests migration * add the extension registration declaratively (using an annotation) Modified getOrganizationId() & getSpaceId() as per V3 adding security groups v3 create api adding create security group impl and tests adding get security group api and tests adding get security group impl + test adding list security groups impl + api adding update security group api adding update security group api v3 impl adding security groups delete api v3 impl and tests adding bind running/staging security group v3 api adding bind impl adding unbind security group adding list running/staging api and tests adding create security group test adding integration tests adding integration tests fixing setup/teardown fixing integration tests refactoring integration tests Ignore .idea/ for real now Migration to Junit5 * tests from radoslav commits Make integration tests chatty * cause they have interesting things to display Add globally enabled Spotless apply; include integration-test mask off non-permission bits apply spotless formatting * on top of Hans Schulz "mask off non-permission bits" porting check route to v3 api porting delete orphaned routes pushing delete route cleaning up leftovers in tests applying default style and fixing missing imports PR #1194: rebase and format with spotless defaultApplication-api minor changes Modified Junit tests to adopt V3 changes. rebasing 1173 fix health check type serialization Update tcp-routes.yml Update tcp-routes.yml Update IntegrationTestConfiguration.java fix formatting test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.