Sorry, something went wrong.
There was a problem hiding this comment.
please keep reformatting in a standalone commit; it makes it really hard to review if changes and reformatting (please configure your IDE not to reformat every single class you updated) are bundled together; thank you!
Actually even better: please stick to the existing code style; some IDEs like IntelliJ recognize the current layout and do not try to reduce lines to a specific length
Sorry, something went wrong.
| @@ -30,7 +30,7 @@ | |||
| import org.cloudfoundry.client.v2.routes.DeleteRouteResponse; | |||
There was a problem hiding this comment.
unused import
Sorry, something went wrong.
There was a problem hiding this comment.
also line 61: import static org.cloudfoundry.util.tuple.TupleUtils.predicate;
Sorry, something went wrong.
| import org.cloudfoundry.client.v2.jobs.GetJobResponse; | ||
| import org.cloudfoundry.client.v2.jobs.JobEntity; | ||
|
|
||
| import org.cloudfoundry.client.v3.jobs.GetJobRequest; |
There was a problem hiding this comment.
lots of unused imports here
Sorry, something went wrong.
There was a problem hiding this comment.
@anthonydahanne Thanks for checking it out. Sure, will do.
Sorry, something went wrong.
|
@anthonydahanne Apologies for the formatting. I've been using the VS Code and it's default styling is a bit off. I've removed the unused imports and reformatted via the standard Eclipse google java style. |
Sorry, something went wrong.
|
@anthonydahanne Apologies for the formatting. I've been using the VS Code and it's default styling is a bit off. I've removed the unused imports and reformatted via the standard Eclipse google java style. Thanks for the effort, but unfortunately, a lot of unchanged code is still reformatted. We need to enforce formatting using CI to make sure we won't be having this discussion anymore. I'll let you know when we have it. Thanks for your patience |
Sorry, something went wrong.
|
This could be closed now because #1217 introduced this change. |
Sorry, something went wrong.
Change adopts V3 API in the following operations: