← 返回首页
Adopting Security Groups API V3 by radoslav-tomov · Pull Request #1185 · cloudfoundry/cf-java-client · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Adopting Security Groups API V3 #1185

Closed
radoslav-tomov wants to merge 21 commits into
cloudfoundry:mainfrom
radoslav-tomov:v3sg
Closed

Adopting Security Groups API V3 #1185
radoslav-tomov wants to merge 21 commits into
cloudfoundry:mainfrom
radoslav-tomov:v3sg

Conversation

radoslav-tomov commented Jul 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adopting Security Groups API V3 API. Change includes implementation, unit and integration tests for the following operations:

PR ended up a bit on the large side, but it is mostly boilerplate, so I decided not to try to brake it further apart.

linux-foundation-easycla Bot commented Jul 7, 2023 •
edited
Loading

Copy link
Copy Markdown



The committers listed above are authorized under a signed CLA.

stephanme mentioned this pull request Jul 11, 2023
Merged
radoslav-tomov marked this pull request as ready for review July 19, 2023 12:13
radoslav-tomov changed the title [WIP]Adopting Security Groups API V3 Adopting Security Groups API V3 Jul 19, 2023
stephanme mentioned this pull request Aug 10, 2023
Merged
anthonydahanne requested changes Oct 4, 2023
View reviewed changes

anthonydahanne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

all tests pass; I've had a quick look, please fix obvious issues (cf screenshots)

thank you

Comment thread integration-test/src/test/java/org/cloudfoundry/client/v3/SecurityGroupsTest.java Outdated Show resolved Hide resolved
Comment thread ...src/main/java/org/cloudfoundry/reactor/client/v3/securitygroups/ReactorSecurityGroupsV3.java Outdated Show resolved Hide resolved

radoslav-tomov commented Oct 16, 2023

Copy link
Copy Markdown
Contributor Author

@anthonydahanne I've removed the unused imports and reformatted via the standard google eclipse style formatter. Fixed the year in the license comment and added it where it was missing. Unfortunately I don't have InteliJ license, so I might have missed some warnings. Let me know if this is the case.

anthonydahanne commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Hello @radoslav-tomov !
It's better, thank you, but still a lot of useless reformating.

But I don't blame you at all; the project should have a linter in place; working on that!

pivotal-david-osullivan added a commit that referenced this pull request Feb 12, 2024
Merge pull request #1215 from anthonydahanne/bunch-of-prs-rebased …
40fd854
Migrate integration tests to Junit 5 and selectively apply changes from #1174 and #1185

anthonydahanne commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

was included and merged with this PR #1215

pivotal-david-osullivan commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

Closing as this work was included in #1215

anthonydahanne mentioned this pull request Jun 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dmikusa Awaiting requested review from dmikusa
pivotal-david-osullivan Awaiting requested review from pivotal-david-osullivan
Gerg Awaiting requested review from Gerg
anthonydahanne Awaiting requested review from anthonydahanne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.