Flake8 code style fixes#241

roaffix

Fix flake8 errors
Fix some FIXME tags
Move to_str method to library from utils to avoid import errors

9prady9

Most of utility abstractions look good although it seems majority of if checks are now contradicting PEP8 style in the following two patterns:

if <var> is None: or if <var> is not None should be preferred over if <var>: per PEP8 guidline - https://www.python.org/dev/peps/pep-0008/#programming-recommendations
if <var> == 0 or <some number> - not sure what's PEP8 stance on this type of comparisons, but numerical comparisons are better written this way to ensure better code readability and understanding instead of if <var>: which seems like checking for None and may lead to confusion.

roaffix

Most of utility abstractions look good although it seems majority of if checks are now contradicting PEP8 style in the following two patterns:

if <var> is None: or if <var> is not None should be preferred over if <var>: per PEP8 guidline - https://www.python.org/dev/peps/pep-0008/#programming-recommendations
if <var> == 0 or <some number> - not sure what's PEP8 stance on this type of comparisons, but numerical comparisons are better written this way to ensure better code readability and understanding instead of if <var>: which seems like checking for None and may lead to confusion.

You are right. Some variables are considered to be None by default, so it should be checked. Nice catch! I'll fix that.
In other cases, some of your checks, e.g., AF_PATH in library.py check if AF_PATH is None, but it should fail if AF_PATH == "". Simple conditions change to if AF_PATH can fix such problems when the default value or variable type is not known.

revert

IMO, it's better now :)

revert

Still, I don't see a point to revert these changes. These variables are just temp variables and they are not changed later anyhow. But we drop extra 7 lines of code.

roaffix

I'm going to postpone this PR till #244 is merged. I will add the arg --flake8 to the pytest for automatic code style checks here right after.

roaffix changed the base branch from master to dev November 13, 2020 04:54

roaffix changed the title Flake8 code stype fixes Flake8 code style fixes Nov 13, 2020

roaffix force-pushed the fix/flake8-refactoring branch from 0d9164c to 04d50ce Compare November 13, 2020 04:57

9prady9 reviewed Nov 13, 2020

View reviewed changes

Comment thread arrayfire/library.py Outdated Show resolved Hide resolved

roaffix force-pushed the fix/flake8-refactoring branch 2 times, most recently from 16f3c01 to 9b328f1 Compare November 13, 2020 17:18

roaffix force-pushed the fix/flake8-refactoring branch from 9b328f1 to ad77595 Compare November 14, 2020 00:12

syurkevi reviewed Nov 14, 2020

View reviewed changes

roaffix force-pushed the fix/flake8-refactoring branch from ad77595 to 6012303 Compare November 14, 2020 01:17

syurkevi reviewed Nov 14, 2020

View reviewed changes

Comment thread arrayfire/array.py Show resolved Hide resolved

roaffix closed this Nov 14, 2020

roaffix force-pushed the fix/flake8-refactoring branch from 6012303 to 28a0f61 Compare November 14, 2020 03:27

roaffix reopened this Nov 14, 2020

roaffix force-pushed the fix/flake8-refactoring branch 4 times, most recently from c20136f to 911be16 Compare November 14, 2020 16:24

Flak8 refactoring. Fix minor bugs and close tags

b7cffa1

roaffix force-pushed the fix/flake8-refactoring branch from 911be16 to b7cffa1 Compare November 14, 2020 16:25

roaffix closed this Nov 14, 2020

-                      location = Source.device
-                  else:
-                      location = Source.host
+                  location = Source.device if is_device else Source.host

-                      high_arr = constant_array(high, vdims[0], vdims[1], vdims[2], vdims[3], vty)
-                  else:
-                      high_arr = high.arr
+                  low_arr = low.arr if is_low_array else constant_array(low, vdims[0], vdims[1], vdims[2], vdims[3], vty)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flake8 code style fixes#241