← 返回首页
Added sparse dense conversion test by edwinsolisf · Pull Request #3589 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Added sparse dense conversion test#3589

Merged
christophe-murphy merged 1 commit into
arrayfire:masterfrom
edwinsolisf:sparse_test
Oct 1, 2024
Merged

Added sparse dense conversion test#3589
christophe-murphy merged 1 commit into
arrayfire:masterfrom
edwinsolisf:sparse_test

Conversation

Copy link
Copy Markdown
Contributor

When converting a sparse COO matrix to a dense matrix using af::dense, the CUDA, oneAPI, and openCL kernels where invoking the coo2dense kernel with incorrect dimensions which was only observable for sparse arrays with nnz greater than 1024 (CUDA) and 8192 (oneAPI/openCL). This tests checks this.

Description

Additional information about the PR answering following questions:

  • Is this a new feature or a bug fix?: Adds a test
  • Why these changes are necessary: Tests uncovered case
  • Potential impact on specific hardware, software or backends: None
  • New functions and their functionality: None
  • Can this PR be backported to older versions?: Yes
  • Future changes not implemented in this PR.: None

Tests pull request #3583

Changes to Users

  • Additional options added to the build: None
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

edwinsolisf force-pushed the sparse_test branch 2 times, most recently from 5caa003 to 804ee11 Compare August 21, 2024 15:52
christophe-murphy merged commit 01c8948 into arrayfire:master Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.