← 返回首页
Fix build failure of cuda backend when cudnn is used. by errata-c · Pull Request #3521 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Fix build failure of cuda backend when cudnn is used.#3521

Merged
christophe-murphy merged 5 commits into
arrayfire:masterfrom
errata-c:cudnn_status_fix
Aug 30, 2024
Merged

Fix build failure of cuda backend when cudnn is used.#3521
christophe-murphy merged 5 commits into
arrayfire:masterfrom
errata-c:cudnn_status_fix

Conversation

Copy link
Copy Markdown
Contributor

errata-c commented Nov 5, 2023

Casts the cudnnStatus_t enumeration to the underlying integer type prior to passing to fmt::format.
Additionally fixes an incorrect call to dependency_check in the test configuration when AF_WITH_EXTERNAL_PACKAGES_ONLY is set.

Description

Fixes: #3506.
Includes type_traits in the src/backend/cuda/platform.cpp file.
Uses only c++11 features.

Changes to Users

No changes to downstream users.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

Copy link
Copy Markdown
Contributor

FloopCZ commented Mar 7, 2024

The PR fixes #3506 for me and the code seems reasonable.
If @errata-c fixes the formatting according to clang-format, can it be merged?

christophe-murphy merged commit 7978352 into arrayfire:master Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Build]

3 participants

Footer

© 2026 GitHub, Inc.