← 返回首页
fix transform operator for countByKey by syurkevi · Pull Request #3175 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix transform operator for countByKey#3175

Merged
umar456 merged 2 commits into
masterfrom
countbykeyfix
Oct 1, 2021
Merged

fix transform operator for countByKey#3175
umar456 merged 2 commits into
masterfrom
countbykeyfix

Conversation

Copy link
Copy Markdown
Contributor

syurkevi commented Sep 28, 2021
edited
Loading

Fixes Issue #3062 where countByKey would give incorrect results for any n > 128 (block size). When there is more than one block's worth of reduction, multiple reduction iterations occur.
The af_nonzero_t transformation would reset the reduced values back to a non-zero flag (1) instead of the actual count between reduction iterations. This operator is now replaced with the af_add_t operator in consequent iterations.

  • Rebased on latest master
  • Code compiles
  • Tests pass

umar456 merged commit 2444ef5 into master Oct 1, 2021
syurkevi deleted the countbykeyfix branch October 4, 2021 15:52
9prady9 added this to the 3.8.1 milestone Oct 5, 2021
9prady9 added the fix label Oct 5, 2021
9prady9 pushed a commit to 9prady9/arrayfire that referenced this pull request Oct 5, 2021
* fix transform operator for countByKey (cherry picked from commit 2444ef5)
syurkevi added a commit that referenced this pull request Dec 28, 2021
* fix transform operator for countByKey (cherry picked from commit 2444ef5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.