← 返回首页
Update CUDA driver version checks by umar456 · Pull Request #3161 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Update CUDA driver version checks#3161

Merged
umar456 merged 5 commits into
arrayfire:masterfrom
umar456:update_cuda
Jul 29, 2021
Merged

Update CUDA driver version checks#3161
umar456 merged 5 commits into
arrayfire:masterfrom
umar456:update_cuda

Conversation

Copy link
Copy Markdown
Member

umar456 commented Jul 26, 2021

Update CUDA driver version information for CUDA 11.4

Description

  • Add minimum driver version checks for 11.4
  • Minor namespace refactoring in platform

Changes to Users

None

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 requested changes Jul 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Let's keep the driver version commit specific that itself. Please move the cleanup changes in that commit to the other commit which already has lot of cleanup and code movement.

Otherwise, looks good.

I am looking into the vcpkg failure, it is not related to this change.

Comment thread src/backend/cuda/device_manager.cpp Outdated
{7000, 346.46f, 347.62f}};
// clang-format on

static inline int getMinSupportedCompute(int cudaMajorVer) {
Copy link
Copy Markdown
Member

9prady9 Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please move this function movement changes into cleanup commit.

Comment thread src/backend/cuda/device_manager.cpp
}

// pulled from CUTIL from CUDA SDK
static inline int compute2cores(unsigned major, unsigned minor) {
Copy link
Copy Markdown
Member

9prady9 Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please move this function movement changes into cleanup commit.

9prady9 previously approved these changes Jul 27, 2021
View reviewed changes
umar456 force-pushed the update_cuda branch 2 times, most recently from 5d1de60 to faf7432 Compare July 27, 2021 15:13
umar456 merged commit 13959d4 into arrayfire:master Jul 29, 2021
9prady9 deleted the update_cuda branch July 30, 2021 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.