← 返回首页
Add missing batch support check in sparse-dense arith ops by 9prady9 · Pull Request #3129 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Add missing batch support check in sparse-dense arith ops#3129

Merged
9prady9 merged 2 commits into
arrayfire:masterfrom
9prady9:fix_sparse_matmul_check
May 5, 2021
Merged

Add missing batch support check in sparse-dense arith ops#3129
9prady9 merged 2 commits into
arrayfire:masterfrom
9prady9:fix_sparse_matmul_check

Conversation

Copy link
Copy Markdown
Member

9prady9 commented May 4, 2021

Description

Fixes: #1988

Changes to Users

Prior to this change, sparse-dense arithmetic API calls incorrectly continued with the operation where batch support was in fact not yet available. Until such support is added later, we need correctly return an appropriate error code.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 added the fix label May 4, 2021
9prady9 added this to the 3.8.1 milestone May 4, 2021
9prady9 requested a review from umar456 May 4, 2021 13:43
9prady9 merged commit ecce064 into arrayfire:master May 5, 2021
9prady9 deleted the fix_sparse_matmul_check branch May 5, 2021 13:56
9prady9 pushed a commit to 9prady9/arrayfire that referenced this pull request Aug 2, 2021
…3129) * Add missing batch support check in sparse-dense arith ops * Fix formatting (cherry picked from commit ecce064)
syurkevi pushed a commit that referenced this pull request Dec 28, 2021
* Add missing batch support check in sparse-dense arith ops * Fix formatting (cherry picked from commit ecce064)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

batchFunc only multiplies first column in a sparse matrix

2 participants

Footer

© 2026 GitHub, Inc.