← 返回首页
Fix const array indexing inside gfor by 9prady9 · Pull Request #3078 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fix const array indexing inside gfor#3078

Merged
9prady9 merged 1 commit into
arrayfire:masterfrom
9prady9:issue3073
Jan 22, 2021
Merged

Fix const array indexing inside gfor#3078
9prady9 merged 1 commit into
arrayfire:masterfrom
9prady9:issue3073

Conversation

Copy link
Copy Markdown
Member

9prady9 commented Jan 13, 2021 •
edited
Loading

Description

Indexing a const array inside GFOR produced results which aren't identical to results generated from indexing a non-const array.
Fixes: #3073

Changes to Users

Identical behavior when indexing const vs non-const array inside gfor.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass - test_inverse_dense_opencl seems to fail after this change, looking into it why, although the specific failing test seems to run fine if run via filter argument to the test program.
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 added the fix label Jan 13, 2021
9prady9 added this to the 3.8.1 milestone Jan 13, 2021
9prady9 requested a review from umar456 January 13, 2021 00:40
Copy link
Copy Markdown
Member Author

9prady9 commented Jan 13, 2021

Doesn't seem like inverse_dense failure on my local machine is related to this change. I think somehow cpu_randu helper is causing it because if I don't use it and use GPU function to generate data for inverse_dense, the tests pass in every run just fine.

9prady9 marked this pull request as ready for review January 13, 2021 01:27
9prady9 merged commit 6ce9d9a into arrayfire:master Jan 22, 2021
9prady9 deleted the issue3073 branch January 22, 2021 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

umar456 umar456 approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

3.8.1

Development

Successfully merging this pull request may close these issues.

[BUG] Different indexing behavior for const vs non-const array

2 participants

Footer

© 2026 GitHub, Inc.