← 返回首页
Fix a infinite recursion bug in NaryNode JIT Node by 9prady9 · Pull Request #3072 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fix a infinite recursion bug in NaryNode JIT Node#3072

Merged
9prady9 merged 5 commits into
arrayfire:masterfrom
9prady9:issue3065
Feb 22, 2021
Merged

Fix a infinite recursion bug in NaryNode JIT Node#3072
9prady9 merged 5 commits into
arrayfire:masterfrom
9prady9:issue3065

Conversation

Copy link
Copy Markdown
Member

9prady9 commented Dec 30, 2020

Description

When the maximum JIT tree height is two, createNaryNode goes into
infinite recursion due to missing base case check inside the function.
Fixes: #3065

Changes to Users

Fixes the infinite recursion bug when maximum jit length is set to 2.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 added the fix label Dec 30, 2020
9prady9 added this to the 3.8.1 milestone Dec 30, 2020
9prady9 requested a review from umar456 December 30, 2020 05:27
9prady9 commented Dec 30, 2020
View reviewed changes
Comment thread test/jit.cpp Outdated Show resolved Hide resolved
Copy link
Copy Markdown
Member Author

9prady9 commented Jan 4, 2021

I think the clang-format error should be fixed once related fix from #3071 is merged. Locally I have made sure the formatting is good.

9prady9 force-pushed the issue3065 branch 3 times, most recently from 52c1d46 to 3114ff8 Compare January 27, 2021 13:35
pradeep added 3 commits February 18, 2021 23:14
Bump up project version to next feature version: 3.9
24a1cd4
Fix a infinite recursion bug in NaryNode JIT Node …
05ed82c
When the maximum JIT tree height is one, createNaryNode goes into infinite recursion. This effects CUDA and OpenCL backends
Check for empty Arrays in JIT evalNodes
be7d729
9prady9 force-pushed the issue3065 branch 4 times, most recently from 5e96383 to 7ce4e6e Compare February 18, 2021 19:31
pradeep added 2 commits February 19, 2021 13:30
Add hidden functions to get/set max jit length for tests …
1ec9002
These functions are not exposed to users. They are not included when generating installers. These functions are purely for testing certain internal behavior given a certain combination of environment variables. Test for unit max JIT height infinite recursion bug
Mark result variables of cmake cmds as advanced …
725b2d1
unmarked CUDA_VERSION as advanced so that users may see what CUDA toolkit is picked up
9prady9 merged commit e50c3a8 into arrayfire:master Feb 22, 2021
9prady9 deleted the issue3065 branch February 22, 2021 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

umar456 umar456 approved these changes

Assignees

No one assigned

Labels

CUDA feature fix OpenCL

Projects

None yet

Milestone

3.8.1

Development

Successfully merging this pull request may close these issues.

[BUG] Setting AF_CUDA_MAX_JIT_LEN to values < 2 produces SIGSEGV

2 participants

Footer

© 2026 GitHub, Inc.