← 返回首页
Remove non-free guards for SIFT/GLOH algorithms by 9prady9 · Pull Request #3071 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Remove non-free guards for SIFT/GLOH algorithms#3071

Merged
9prady9 merged 2 commits into
arrayfire:masterfrom
9prady9:free_sift
Jan 21, 2021
Merged

Remove non-free guards for SIFT/GLOH algorithms#3071
9prady9 merged 2 commits into
arrayfire:masterfrom
9prady9:free_sift

Conversation

Copy link
Copy Markdown
Member

9prady9 commented Dec 29, 2020

Description

SIFT patent expired recently and these algorithms can be provided as part of open source binaries that are distributed from our
website.

Fixes: #3007

Changes to Users

None to existing users. New users will be able to use sift/gloh functions from the installations done using our website binaries.

Checklist

  • Rebased on latest master
  • Code compiles
  • [ ] Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 added this to the 3.8.1 milestone Dec 29, 2020
9prady9 requested a review from umar456 December 29, 2020 17:12
9prady9 force-pushed the free_sift branch 3 times, most recently from 6d853b5 to 6d73f23 Compare December 29, 2020 17:33
9prady9 mentioned this pull request Jan 4, 2021
Merged
3 tasks
umar456 previously approved these changes Jan 11, 2021
View reviewed changes
9prady9 force-pushed the free_sift branch 3 times, most recently from a0b2d39 to 6bb51f2 Compare January 12, 2021 13:06
Remove non-free guards for SIFT/GLOH algorithms …
1af2d82
SIFT patent expired recently and these algorithms can be provided as part of open source binaries that are distributed from our website.
9prady9 force-pushed the free_sift branch 4 times, most recently from cd1d4dd to 7985cb0 Compare January 19, 2021 04:06
9prady9 merged commit 43b34a9 into arrayfire:master Jan 21, 2021
9prady9 deleted the free_sift branch January 21, 2021 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

syurkevi syurkevi approved these changes

umar456 umar456 left review comments

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

3.8.1

Development

Successfully merging this pull request may close these issues.

Moving SIFT to main repo

3 participants

Footer

© 2026 GitHub, Inc.