← 返回首页
Add move constructor and operator= for dim4, Array<T> SparseArray<T> by umar456 · Pull Request #2946 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Add move constructor and operator= for dim4, Array<T> SparseArray<T>#2946

Merged
9prady9 merged 1 commit into
arrayfire:masterfrom
umar456:nothrow_move
Jul 9, 2020
Merged

Add move constructor and operator= for dim4, Array<T> SparseArray<T>#2946
9prady9 merged 1 commit into
arrayfire:masterfrom
umar456:nothrow_move

Conversation

Copy link
Copy Markdown
Member

umar456 commented Jun 26, 2020

Add nothrow move constructors for dim4. Array, SparseArray

Description

Create move constructors and move assignment operators for Array, SparseArray,
dim4. This adds move constructors for dim4 so this cannot be back ported.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

umar456 added this to the 3.8.0 milestone Jun 26, 2020
9prady9 reviewed Jun 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

No throw move constructors for CPU backend Array are not added. Any specific reason ?

Copy link
Copy Markdown
Member Author

umar456 commented Jun 26, 2020

That static check and constructor was added in the osx_fixes PR. I couldn't add it to these classes because of dim4's move assignment operator and constructor.

Copy link
Copy Markdown
Member

9prady9 commented Jun 26, 2020

Got it. I didn't pull latest master after that PR merge, hence when I checked the file locally didn't find them in CPU backend.

9prady9 merged commit 0308a5c into arrayfire:master Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.