← 返回首页
Fix pinnedMemManager check. Fix MKL Sequential layer by umar456 · Pull Request #2840 · arrayfire/arrayfire · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fix pinnedMemManager check. Fix MKL Sequential layer#2840

Merged
umar456 merged 2 commits into
arrayfire:masterfrom
umar456:mkl_sequential
Apr 14, 2020
Merged

Fix pinnedMemManager check. Fix MKL Sequential layer#2840
umar456 merged 2 commits into
arrayfire:masterfrom
umar456:mkl_sequential

Conversation

Copy link
Copy Markdown
Member

umar456 commented Apr 14, 2020

  • The setMemorymanagerPinned function was incorrectly checking the function pointer instead of the pinnedMemManager pointer.
  • MKL with the Sequential layer was broken because the ThreadingLibrary variable was required. The sequential layer does not have a threading library so MKL was set to not found because that variable was not set.

umar456 added this to the 3.7.2 milestone Apr 14, 2020
9prady9 requested changes Apr 14, 2020
View reviewed changes
Comment thread CMakeModules/FindMKL.cmake Show resolved Hide resolved
umar456 merged commit 9d268cd into arrayfire:master Apr 14, 2020
umar456 deleted the mkl_sequential branch June 26, 2020 18:43
umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.2

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.