You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Dismiss alert
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
For v9+ (ESM) dev builds, the webpack config called useSourceMapFiles(), which overwrote env.sourceMap with 'inline-source-map'. This had two problems:
env.sourceMap was silently ignored. Since NativeScript 9, passing --env.sourceMap=<type> (e.g. source-map) on a dev build had no effect — the user's value was clobbered before getSourceMapType() ever saw it, so builds always emitted inline source maps regardless of what was requested.
File (external) source maps were effectively lost. Everything was forced inline, even though the Android and iOS runtimes are capable of loading .map files.
What is the new behavior?
The clobbering of env.sourceMap is removed. Instead, the v9+ dev-build path only adjusts a local defaultSourceMap fallback (now 'source-map'), which is used solely when the user hasn't specified env.sourceMap:
env.sourceMap is always respected again. A user-provided --env.sourceMap=<type> (or =true/=false) now flows through getSourceMapType() unchanged, on both dev and production builds.
File source maps are restored as the default for v9+ dev builds, so the Android/iOS runtimes once again handle external .map files properly instead of everything being inlined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
For v9+ (ESM) dev builds, the webpack config called useSourceMapFiles(), which overwrote env.sourceMap with 'inline-source-map'. This had two problems:
What is the new behavior?
The clobbering of env.sourceMap is removed. Instead, the v9+ dev-build path only adjusts a local defaultSourceMap fallback (now 'source-map'), which is used solely when the user hasn't specified env.sourceMap: