🤖 Nx Cloud AI Fix EligibleAn automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs. To disable these notifications, a workspace admin can disable them in workspace settings. View your CI Pipeline Execution ↗ for commit 50819dc
☁️ Nx Cloud last updated this comment at 2025-11-05 19:14:37 UTC |
Sorry, something went wrong.
|
What made you use this property? I don't recall any hidden property in the View API. |
Sorry, something went wrong.
|
We have hidden as well. The changes look accurate, had to adjust few things but it just ensures when using it on proxy that it’s children we marked hidden since proxy is not a native view itself. |
Sorry, something went wrong.
|
We have hidden as well. The changes look accurate, had to adjust few things but it just ensures when using it on proxy that it’s children we marked hidden since proxy is not a native view itself. That's my bad, thanks for the correction @NathanWalker! |
Sorry, something went wrong.
|
@KL2400040448 @NathanWalker Instead of meddling with the property like this, maybe we can add an event listener for it. function onHiddenPropertyChange(args: EventData) {
const view = args.object as ProxyViewContainer;
view.eachChildView((child) => {
child.hidden = view.hidden;
return true;
});
}
@CSSType('ProxyViewContainer')
export class ProxyViewContainer extends LayoutBase {
private proxiedLayoutProperties = new Set<string>();
constructor() {
super();
this.nativeViewProtected = undefined;
this.on('hiddenProperty', onHiddenPropertyChange);
}
...
}
This isn't as hackish as current solution and doesn't need ignore comments. |
Sorry, something went wrong.
There was a problem hiding this comment.
approve to merge
Sorry, something went wrong.
|
✅ Rebased and resolved merge conflict. |
Sorry, something went wrong.
|
Hi @NathanWalker 👋 |
Sorry, something went wrong.
|
Hi @NathanWalker 👋 |
Sorry, something went wrong.
|
|
||
| /* | ||
| * Register/unregister existing children with the parent layout. | ||
| */ |
There was a problem hiding this comment.
Curious why valid comments removed?
Sorry, something went wrong.
|
|
||
| /** | ||
| * Layout property changed, proxy the new value to the child view(s) | ||
| */ |
There was a problem hiding this comment.
Same here.
Sorry, something went wrong.
|
|
||
| /** | ||
| * Apply the layout property to the child view. | ||
| */ |
There was a problem hiding this comment.
Another here.
Sorry, something went wrong.
| 'colSpan', | ||
| 'row', | ||
| 'rowSpan', | ||
| ]; |
There was a problem hiding this comment.
Same deal here. comments within are valid context.
Sorry, something went wrong.
| * removing children, so that they can update private measure data. | ||
| * | ||
| * We register our children with the parent to avoid breakage. | ||
| */ |
There was a problem hiding this comment.
Same here.
Sorry, something went wrong.
This PR fixes an issue where setting ProxyViewContainer.hidden = true did not hide its child views.
Problem
ProxyViewContainer is a virtual container that does not create a native view.
As a result, toggling its hidden property had no visible effect — its child views remained visible.
Solution
Override the hidden property to propagate the hidden state to all child views:
public set hidden(value: boolean) {
super.hidden = value;
this.eachChildView((child) => {
child.hidden = value;
return true;
});
}