← 返回首页
Implementation of property definitions by ml-evs · Pull Request #1425 · Materials-Consortia/optimade-python-tools · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Implementation of property definitions#1425

Draft
ml-evs wants to merge 2 commits into
mainfrom
ml-evs/add_property_definitions
Draft

Implementation of property definitions#1425
ml-evs wants to merge 2 commits into
mainfrom
ml-evs/add_property_definitions

Conversation

Copy link
Copy Markdown
Member

ml-evs commented Dec 6, 2022 •
edited
Loading

Rough attempt to begin closing #1416. Still lots to do, and maybe to push back on upstream.

To-do:

  • Update entry info models with JSONSchema
  • Update OpenAPI schemas
  • Finalise all descriptions
  • Validation of fields, e.g., if type = "object", does the nested definition have the right type?
  • Convert existing OPTIMADE field definitions over to new format
  • Testing...
  • Docs
  • Hook into existing provider fields config to construct definitions

ml-evs added schema Concerns the schema models server Issues pertaining to the example server implementation models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Dec 6, 2022
ml-evs added this to the OPTIMADE v1.2 milestone Dec 6, 2022
ml-evs mentioned this pull request Dec 14, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models server Issues pertaining to the example server implementation

Projects

None yet

Milestone

OPTIMADE v1.2

Development

Successfully merging this pull request may close these issues.

1 participant

Footer

© 2026 GitHub, Inc.