Fixed issue where file handler would sometimes return null for existing files; Optimized LIVELOAD file handler.#118

Katsute

Prerequisites

If all checks are not passed then the pull request will be closed.

My code follows the style listed in CONTRIBUTING.
I have checked that no other similar pull requests already exists.
Build compiles.
Build runs without exceptions.
I have added/modified documentation (if applicable).
I have added/modified test cases.

Changes Made

List changes made and/or relevant issues. Please keep changed in reverse chronological order (newest at top).

simplehttpserver/src/main/java/com/kttdevelopment/simplehttpserver/handler/DirectoryEntry.java

Lines 171 to 175 in ab1a8fd

    
           if(entry == null){ // add new entry if not already added and file exists 
        
               final File file = getFile(path); 
        
               return file != null && file.exists() 
        
                   ? files.put(context, new FileEntry(file, adapter, loadingOption)) 
        
                   : null;

Fixed Folder that exists causes file handler to return null file. #117, The solution was already in the above comment, the bug was just a typo.
Optimized directory entry (fixed memory issue caused by saving files in liveload).

Fix #117

ab1a8fd

Katsute added the bug Something isn't working as expected label Nov 16, 2020

Katsute self-assigned this Nov 16, 2020

Katsute added this to the 4.2.0 milestone Nov 16, 2020

Katsute added 2 commits November 16, 2020 17:52

bump version

a97aa8a

Optimized directory entry …

33f2ff9

Fixed files being added on liveload (this would cause memory issues over time).

Katsute added the optimization Optimizations label Nov 16, 2020

Katsute changed the title Fixed issue where file handler would sometimes return null for existing files. Fixed issue where file handler would sometimes return null for existing files; Optimized LIVELOAD file handler. Nov 16, 2020

Katsute merged commit e35aa59 into main Nov 17, 2020

Katsute deleted the fix#117@d15bc78 branch November 17, 2020 00:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed issue where file handler would sometimes return null for existing files; Optimized LIVELOAD file handler.#118