← 返回首页
Add register student use case by OctaviPascual · Pull Request #60 · CodelyTV/java-ddd-example · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Add register student use case#60

Draft
OctaviPascual wants to merge 9 commits into
CodelyTV:mainfrom
OctaviPascual:register-student
Draft

Add register student use case#60
OctaviPascual wants to merge 9 commits into
CodelyTV:mainfrom
OctaviPascual:register-student

Conversation

OctaviPascual commented Nov 8, 2020 •
edited
Loading

Copy link
Copy Markdown

[WIP]
I'm using this branch to implement each of the features of each step.

OctaviPascual commented Nov 10, 2020
View reviewed changes
Comment thread src/shared/main/tv/codely/shared/domain/EmailValueObject.java
import java.util.Objects;

public abstract class EmailValueObject {
private static final EmailValidator emailValidator = new EmailValidator();

OctaviPascual Nov 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I think a better approach would be to create an EmailValidator interface to not contaminate our domain with this dependency, but I tried to do it and I didn't manage to inject the implementation into this abstract class. Is it possible to do it?

OctaviPascual marked this pull request as draft November 11, 2020 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Footer

© 2026 GitHub, Inc.