Contributing

If you are interested in contributing to NVIDIA cuVS, your contributions will fall into three categories:

1. You want to report a bug, feature request, or documentation issue
   • File an issue describing what you encountered or what you want to see changed.
   • The RAPIDS team will evaluate the issues and triage them, scheduling them for a release. If you believe the issue needs priority attention comment on the issue to notify the team.
2. You want to propose a new Feature and implement it
   • Post about your intended feature, and we shall discuss the design and implementation.
   • Once we agree that the plan looks good, go ahead and implement it, using the code contributions guide below.
3. You want to implement a feature or bug-fix for an outstanding issue
   • Follow the code contributions guide below.
   • If you need more context on a particular issue, please ask and we shall provide.

Code contributions

Performance-critical changes require proper benchmarks. Pull requests that affect performance-critical paths will not be merged until those benchmarks are produced; there are no exceptions to this rule.

Your first issue

1. Read the project’s README.md to learn how to setup the development environment
2. Find an issue to work on. The best way is to look for the good first issue or help wanted labels
3. Comment on the issue saying you are going to work on it
4. Code! Make sure to update unit tests!
5. When done, create your pull request
6. Verify that CI passes all status checks. Fix if needed
7. Wait for other developers to review your code and update code as needed
8. Once reviewed and approved, a RAPIDS developer will merge your pull request

Remember, if you are unsure about anything, don’t hesitate to comment on issues and ask for clarifications!

Python / Pre-commit hooks

CUVS uses pre-commit to execute code linters and formatters such as Black, isort, and flake8. These tools ensure a consistent code format throughout the project. Using pre-commit ensures that linter versions and options are aligned for all developers. Additionally, there is a CI check in place to enforce that committed code follows our standards.

To use pre-commit, install via conda or pip:

Then run pre-commit hooks before committing code:

Optionally, you may set up the pre-commit hooks to run automatically when you make a git commit. This can be done by running:

Now code linters and formatters will be run each time you commit changes.

You can skip these checks with git commit --no-verify or with the short version git commit -n.

Seasoned developers

Once you have gotten your feet wet and are more comfortable with the code, you can look at the prioritized issues of our next release in our project boards.

Pro Tip: Always look at the release board with the highest number for issues to work on. This is where RAPIDS developers also focus their efforts.

Look at the unassigned issues, and find an issue you are comfortable with contributing to. Start with Step 3 from above, commenting on the issue to let others know you are working on it. If you have any questions related to the implementation of the issue, ask them in the issue instead of the PR.

Attribution

Portions adopted from https://github.com/pytorch/pytorch/blob/master/CONTRIBUTING.md