← 返回首页
Uncontrolled data in arithmetic expression — CodeQL query help documentation CodeQL docs
CodeQL documentation
CodeQL resources

Uncontrolled data in arithmetic expression

ID: cpp/uncontrolled-arithmetic Kind: path-problem Security severity: 8.6 Severity: warning Precision: high Tags: - security - external/cwe/cwe-190 - external/cwe/cwe-191 Query suites: - cpp-code-scanning.qls - cpp-security-extended.qls - cpp-security-and-quality.qls

Click to see the query in the CodeQL repository

Performing calculations on uncontrolled data can result in integer overflows unless the input is validated.

If the data is not under your control, and can take extremely large values, even arithmetic operations that would usually result in a small change in magnitude may result in overflows.

Recommendation

Always guard against overflow in arithmetic operations on uncontrolled data by doing one of the following:

Example

In this example, a random integer is generated. Because the value is not controlled by the programmer, it could be extremely large. Performing arithmetic operations on this value could therefore cause an overflow. To avoid this happening, the example shows how to perform a check before performing an arithmetic operation.

int main(int argc, char** argv) { int i = rand(); // BAD: potential overflow int j = i + 1000; // ... int n = rand(); int k; // GOOD: use a guard to prevent overflow if (n < INT_MAX-1000) k = n + 1000; else k = INT_MAX; }

References